fix: change var name of pev to evspsblpot in forcing file fixes #11 #12
Conversation
There was a problem hiding this comment.
Hi Rolf, I just noticed that I had not looked at this yet.
Are you sure that things work correctly now? In the eWaterCycle fork of HBV-bmi I also added some unit checks and conversions. See this diff for the differences between David's version and the fork.
The CMOR formatted data uses kg/m2/s as units for pr and evspblpot. I.e. mm/s. While this HBV-bmi implementation uses mm/d (a bit more intuitive in a hydrology context).
Seeing how important the Python HBV implementation has become for eWaterCycle (both in teaching as well as your climate change impact study), maybe it would make sense to have @MarkMelotto take up unifying/cleaning up the eWaterCycle HBV and model+plugin. Working on this could help with getting a better understanding on the ecosystem. But I do understand that Mark has a lot of other tasks to work on as well!
HBV-bmi + ewatercycle-hbv could then be showcased as reference implementations (besides the barebones leakybucket template).
changed the "pev" in the docstring to "evspsblpot"
|
Changed the docstring |
removed to do Co-authored-by: Bart Schilperoort <[email protected]>
because generic lumped forcing was made consistent with EMSValTool names for potential evaporation, this broke. Now fixed by changing to correct var names